[ 
https://issues.apache.org/jira/browse/AMQNET-817?focusedWorklogId=965154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-965154
 ]

ASF GitHub Bot logged work on AMQNET-817:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Apr/25 07:49
            Start Date: 08/Apr/25 07:49
    Worklog Time Spent: 10m 
      Work Description: alaendle commented on code in PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#discussion_r2032606021


##########
src/NMS.AMQP/NmsConnectionFactory.cs:
##########
@@ -367,6 +375,9 @@ private void SetUriOptions(StringDictionary options)
         {
             StringDictionary nmsOptions = 
PropertyUtil.FilterProperties(options, "nms.");
             PropertyUtil.SetProperties(this, nmsOptions);
+
+            StringDictionary amqpOptions = 
PropertyUtil.FilterProperties(options, "amqp.");

Review Comment:
   Sorry - don't know why I've missed that at the first place. Thanks for the 
hint.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 965154)
    Time Spent: 1h 10m  (was: 1h)

> Add ability to configure hostname/vhost in AMQP Open frame
> ----------------------------------------------------------
>
>                 Key: AMQNET-817
>                 URL: https://issues.apache.org/jira/browse/AMQNET-817
>             Project: ActiveMQ .Net
>          Issue Type: New Feature
>          Components: AMQP
>    Affects Versions: AMQP-2.0.0
>            Reporter: Dan Langford
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The AMQP protocol supports "virtual hosts" implemented via the Open frame, 
> the HostName field. 
> QPID Broker-J default hostname/vhost is "default". RabbitMQ default 
> hostname/vhost is "/". The current implementation reuses the URI host which 
> is quite often not correct. 
>  >           open.HostName = remoteUri.Host;
> There should be a way to set the "hostname" or "virtual host"
> In the amqpnetlite client it is set like this
> {{_connection = await Connection.Factory.CreateAsync(new Address(Address), 
> new Open() \{ HostName="default"});}}
> {{ }}
> One way to implement this could be a connection uri parameter much like QPID 
> JMS Client does with *amqp.vhost* option 
> [https://qpid.apache.org/releases/qpid-jms-2.1.0/docs/index.html]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to