[
https://issues.apache.org/jira/browse/ARTEMIS-5371?focusedWorklogId=965165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-965165
]
ASF GitHub Bot logged work on ARTEMIS-5371:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/25 08:47
Start Date: 08/Apr/25 08:47
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #5587:
URL: https://github.com/apache/activemq-artemis/pull/5587#discussion_r2032496264
##########
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java:
##########
@@ -309,16 +311,18 @@ private ServerConnector
createServerConnector(HttpConfiguration httpConfiguratio
addStoreResourceScannerTask(binding.getTrustStorePath(),
binding.getTrustStoreType(), sslFactory);
}
- SslConnectionFactory sslConnectionFactory = new
SslConnectionFactory(sslFactory, "HTTP/1.1");
-
SecureRequestCustomizer secureRequestCustomizer = new
SecureRequestCustomizer();
secureRequestCustomizer.setSniHostCheck(binding.getSniHostCheck() !=
null ? binding.getSniHostCheck() : DEFAULT_SNI_HOST_CHECK_VALUE);
secureRequestCustomizer.setSniRequired(binding.getSniRequired() !=
null ? binding.getSniRequired() : DEFAULT_SNI_REQUIRED_VALUE);
httpConfiguration.addCustomizer(secureRequestCustomizer);
httpConfiguration.setSendServerVersion(false);
HttpConnectionFactory httpFactory = new
HttpConnectionFactory(httpConfiguration);
- connector = new ServerConnector(server, sslConnectionFactory,
httpFactory);
+ HTTP2ServerConnectionFactory h2 = new
HTTP2ServerConnectionFactory(httpConfiguration);
+ ALPNServerConnectionFactory alpn = new ALPNServerConnectionFactory();
+ alpn.setDefaultProtocol("HTTP/1.1");
Review Comment:
I found the following jetty enum for the http versions:
org.eclipse.jetty.http.HttpVersion
```suggestion
alpn.setDefaultProtocol(HttpVersion.HTTP_1_1.asString());
```
Issue Time Tracking
-------------------
Worklog Id: (was: 965165)
Time Spent: 20m (was: 10m)
> Support HTTP/2 from the embedded web server
> -------------------------------------------
>
> Key: ARTEMIS-5371
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5371
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
