[
https://issues.apache.org/jira/browse/ARTEMIS-5376?focusedWorklogId=969531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-969531
]
ASF GitHub Bot logged work on ARTEMIS-5376:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/25 13:51
Start Date: 13/May/25 13:51
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on PR #5593:
URL:
https://github.com/apache/activemq-artemis/pull/5593#issuecomment-2876614253
@jbertram @clebertsuconic
Sorry for taking so long to get back to you on this. I believe these changes
should cover the cases you noted.
I don't really like the change on how to handle the LVQ case, though at this
moment I don't know how to handle it differently while also making use of the
`QueueIterateAction` (`refRemoved` has to be called before `addTail` for LVQs
to keep the correct `current` value).
Regardless, this should be working as intended and without locking... if you
have any suggestions on a better approach for the LVQ case just let me know.
Issue Time Tracking
-------------------
Worklog Id: (was: 969531)
Time Spent: 50m (was: 40m)
> Include all messages in queue management operations
> ---------------------------------------------------
>
> Key: ARTEMIS-5376
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5376
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, some queue management operations act on all messages (including
> paged and scheduled messages) and some don't. Some operations use their own
> iterator logic (internally) and some use a common method.
> This change aims to improve this by adding some functionality into the
> 'QueueIterateAction' class and then have additional management operations use
> it (so that their behavior is consistent with regards to what messages they
> target and how)
> As of now I have left expire and delete reference/references out as I wasn't
> 100% sure it wont have any adverse effects. If desired, they should be
> trivial to add as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
