[
https://issues.apache.org/jira/browse/ARTEMIS-5500?focusedWorklogId=971090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-971090
]
ASF GitHub Bot logged work on ARTEMIS-5500:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/25 13:55
Start Date: 29/May/25 13:55
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5718:
URL: https://github.com/apache/activemq-artemis/pull/5718#discussion_r2114032860
##########
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTConnectionManager.java:
##########
@@ -28,14 +28,7 @@
import org.apache.activemq.artemis.core.server.impl.ServerSessionImpl;
import org.apache.activemq.artemis.utils.UUIDGenerator;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.ASSIGNED_CLIENT_IDENTIFIER;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.AUTHENTICATION_METHOD;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.MAXIMUM_PACKET_SIZE;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.RECEIVE_MAXIMUM;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.SERVER_KEEP_ALIVE;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.SESSION_EXPIRY_INTERVAL;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.TOPIC_ALIAS_MAXIMUM;
-import static
io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.WILL_DELAY_INTERVAL;
+import static io.netty.handler.codec.mqtt.MqttProperties.MqttPropertyType.*;
Review Comment:
Star imports like this are not allowed due to CheckStyle rules.
Issue Time Tracking
-------------------
Worklog Id: (was: 971090)
Time Spent: 20m (was: 10m)
> MQTT5 Additional CONNACK properties
> -----------------------------------
>
> Key: ARTEMIS-5500
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5500
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: MQTT
> Reporter: Evgeniy Devyatykh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901080]
> I propose to add following CONNACK properties:
> 3.2.2.3.5 Retain Available declares whether the Server supports retained
> messages
> 3.2.2.3.11 Wildcard Subscription Available declares whether the Server
> supports Wildcard Subscriptions.
> 3.2.2.3.12 Subscription Identifiers Available declares whether the Server
> supports Subscription Identifiers.
> 3.2.2.3.13 Shared Subscription Available declares whether the Server supports
> Shared Subscriptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
