[
https://issues.apache.org/jira/browse/AMQ-9719?focusedWorklogId=972032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-972032
]
ASF GitHub Bot logged work on AMQ-9719:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/25 22:43
Start Date: 05/Jun/25 22:43
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1445:
URL: https://github.com/apache/activemq/pull/1445#discussion_r2130748267
##########
activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java:
##########
@@ -120,15 +121,13 @@ protected static void
setupFeatures(DocumentBuilderFactory factory) {
}
}
}
- if (features.size() > 0) {
- StringBuilder featureString = new StringBuilder();
+ StringJoiner featureString = new StringJoiner(", ");
Review Comment:
You could move this inside the if statement so we are not constructing a new
StringJoiner unless we need it
Issue Time Tracking
-------------------
Worklog Id: (was: 972032)
Time Spent: 0.5h (was: 20m)
> Two StringBuffers are updated, but the value isn't used
> -------------------------------------------------------
>
> Key: AMQ-9719
> URL: https://issues.apache.org/jira/browse/AMQ-9719
> Project: ActiveMQ Classic
> Issue Type: Bug
> Reporter: Dmitrii Kriukov
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Sample:
> line 124 in XPathExpression
> StringBuffer featureString = new StringBuffer();
> I will provide a PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
