[
https://issues.apache.org/jira/browse/ARTEMIS-5609?focusedWorklogId=977714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-977714
]
ASF GitHub Bot logged work on ARTEMIS-5609:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/25 14:02
Start Date: 05/Aug/25 14:02
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5854:
URL: https://github.com/apache/activemq-artemis/pull/5854#discussion_r2254459932
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java:
##########
@@ -140,7 +159,12 @@ public RemotingServiceImpl(final ClusterManager
clusterManager,
final ServiceRegistry serviceRegistry) {
this.serviceRegistry = serviceRegistry;
- acceptorsConfig = config.getAcceptorConfigurations();
+ if (config.getAcceptorConfigurations() != null &&
!config.getAcceptorConfigurations().isEmpty()) {
+ acceptorsConfig = config.getAcceptorConfigurations().stream()
+
.collect(Collectors.toMap(c -> c.getName(), Function.identity()));
+ } else {
+ acceptorsConfig = Collections.emptyMap();
Review Comment:
Good catch. I guess that was the point initially, but you are correct that
if none were present initially, but then some were attempted to be added, it
would try to do a putAll on this map.
Issue Time Tracking
-------------------
Worklog Id: (was: 977714)
Time Spent: 0.5h (was: 20m)
> Add support for (add/remove/update) of acceptors via config reload
> ------------------------------------------------------------------
>
> Key: ARTEMIS-5609
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5609
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Affects Versions: 2.42.0
> Reporter: Timothy A. Bish
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.43.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Acceptors are not part of config reload at the moment.
> [https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html]
> In support of an multi-tenant deployment, having the ability to onboard a new
> acceptor to a running broker is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
