[ https://issues.apache.org/jira/browse/AMQ-9691?focusedWorklogId=977843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-977843 ]
ASF GitHub Bot logged work on AMQ-9691: --------------------------------------- Author: ASF GitHub Bot Created on: 06/Aug/25 13:25 Start Date: 06/Aug/25 13:25 Worklog Time Spent: 10m Work Description: therepanic commented on code in PR #1478: URL: https://github.com/apache/activemq/pull/1478#discussion_r2257140784 ########## activemq-broker/src/main/java/org/apache/activemq/store/MessageStoreStatistics.java: ########## @@ -28,24 +28,23 @@ public class MessageStoreStatistics extends StatsImpl { protected CountStatisticImpl messageCount; protected SizeStatisticImpl messageSize; - + protected long createdTimestamp; public MessageStoreStatistics() { this(true); } public MessageStoreStatistics(boolean enabled) { - messageCount = new CountStatisticImpl("messageCount", "The number of messages in the store passing through the destination"); messageSize = new SizeStatisticImpl("messageSize","Size of messages in the store passing through the destination"); + createdTimestamp = System.currentTimeMillis(); Review Comment: Should we create another constructor where the second argument will be `createdTimestamp`? Or is the current version OK? ########## activemq-broker/src/main/java/org/apache/activemq/store/MessageStoreStatistics.java: ########## @@ -28,24 +28,23 @@ public class MessageStoreStatistics extends StatsImpl { protected CountStatisticImpl messageCount; protected SizeStatisticImpl messageSize; - + protected long createdTimestamp; public MessageStoreStatistics() { this(true); } public MessageStoreStatistics(boolean enabled) { - messageCount = new CountStatisticImpl("messageCount", "The number of messages in the store passing through the destination"); messageSize = new SizeStatisticImpl("messageSize","Size of messages in the store passing through the destination"); + createdTimestamp = System.currentTimeMillis(); Review Comment: Should we create another constructor where the second argument will be `createdTimestamp` or is the current version OK? Issue Time Tracking ------------------- Worklog Id: (was: 977843) Time Spent: 0.5h (was: 20m) > Add createdTimestamp to MessageStoreStatistics > ---------------------------------------------- > > Key: AMQ-9691 > URL: https://issues.apache.org/jira/browse/AMQ-9691 > Project: ActiveMQ Classic > Issue Type: Improvement > Reporter: Matt Pavlovich > Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > This would allow tracking how long a destination has existing in a broker > over all time. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact