[
https://issues.apache.org/jira/browse/AMQ-9769?focusedWorklogId=985098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-985098
]
ASF GitHub Bot logged work on AMQ-9769:
---------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/25 05:39
Start Date: 30/Sep/25 05:39
Worklog Time Spent: 10m
Work Description: thezbyg commented on code in PR #1493:
URL: https://github.com/apache/activemq/pull/1493#discussion_r2389915659
##########
activemq-web-console/src/main/webapp/WEB-INF/tags/jms/forEachConnection.tag:
##########
@@ -23,9 +23,8 @@
<%
Iterator it = broker.getConnections(connectorName).iterator();
while (it.hasNext()) {
- String conName = (String) it.next();
- ConnectionViewMBean con = broker.getConnection(conName);
- request.setAttribute(connectionName, conName);
+ ConnectionViewMBean con = (ConnectionViewMBean) it.next();
+ request.setAttribute(connectionName, con.getClientId());
Review Comment:
@jbonofre
Connection MBeans with `connectionViewType=clientId` type use connection
`clientId` value for `connectionName` parameter, so `connectionName` MBean
parameter value and `clientId` connection property value should be equivalent.
This is the code responsible for `connectionName` value in connection MBean:
https://github.com/apache/activemq/blob/51553ddc5f4fac3cd8d89dc5cf485d5d527d60d1/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagedTransportConnection.java#L84
https://github.com/apache/activemq/blob/51553ddc5f4fac3cd8d89dc5cf485d5d527d60d1/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagedTransportConnection.java#L117
https://github.com/apache/activemq/blob/51553ddc5f4fac3cd8d89dc5cf485d5d527d60d1/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerMBeanSupport.java#L181
@mattrpav
If JMS allows multiple connections with same `clientId` value, then it
should have already caused problems by attempting to create multiple MBeans
with the same name. If this was not an issue before my changes, then I will
have to investigate more, because I thought that `clientId` must always be
unique and can not be shared between connections.
Issue Time Tracking
-------------------
Worklog Id: (was: 985098)
Time Spent: 50m (was: 40m)
> Add name property to connector interface and MBean
> --------------------------------------------------
>
> Key: AMQ-9769
> URL: https://issues.apache.org/jira/browse/AMQ-9769
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker, Web Console
> Reporter: Albertas Vyšniauskas
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {color:#000000}{color:#000000}ConnectorViewMBean{color}{color} does not have
> a name property and the only way to get connector name from MBean is
> "connectorName" JMX value. This is bad because JMX values are escaped and
> this escaping is non-reversible, so it is impossible to get the original
> connector name.
> Web console could use this new name property to show original connector name
> instead of the one mangled by JMX escaping.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
