[
https://issues.apache.org/jira/browse/ARTEMIS-5733?focusedWorklogId=989613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-989613
]
ASF GitHub Bot logged work on ARTEMIS-5733:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/25 14:10
Start Date: 30/Oct/25 14:10
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #6020:
URL:
https://github.com/apache/activemq-artemis/pull/6020#issuecomment-3468221790
Nice find! A single character bug fix.
I recommend removing your existing test and adding this to the tests in
`activemq-core-client`:
```java
package org.apache.activemq.artemis.core.client.impl;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
import org.mockito.Mockito;
public class AsynchronousProducerCreditsImplTest {
@Test
@Timeout(10)
public void testZeroCredits() throws Exception {
ClientSessionInternal session =
Mockito.mock(ClientSessionInternal.class);
AsynchronousProducerCreditsImpl producerCredits = new
AsynchronousProducerCreditsImpl(session, null, 0,
Mockito.mock(ClientProducerFlowCallback.class));
producerCredits.receiveCredits(0);
Mockito.verify(session).sendProducerCreditsMessage(0, null);
}
}
```
This test is simpler, faster, and reproduces the problem every time.
Issue Time Tracking
-------------------
Worklog Id: (was: 989613)
Time Spent: 0.5h (was: 20m)
> Core bridge can lock on flow control
> ------------------------------------
>
> Key: ARTEMIS-5733
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5733
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Anton Roskvist
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Landing on a balance of 0 credits, the bridge can lock with no chance of
> recovery besides a re-deploy of the bridge.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact