[ 
https://issues.apache.org/jira/browse/AMQ-9392?focusedWorklogId=990326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990326
 ]

ASF GitHub Bot logged work on AMQ-9392:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Nov/25 00:37
            Start Date: 05/Nov/25 00:37
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on PR #1119:
URL: https://github.com/apache/activemq/pull/1119#issuecomment-3488571504

   I did some testing and confirmed that things do seem to clean up ok on 
normal exception with the transport listener.
   
   However, I also confirmed that this patch will indeed destroy the thread 
pool 
[here](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/AbstractInactivityMonitor.java#L446)
 during connection initialization if there are no other connections yet, just 
to immediately re-create it again 
[here](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/AbstractInactivityMonitor.java#L476)
 because the stopConnectCheckTask() method is 
[called](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/InactivityMonitor.java#L57)
 as part of the normal initialization of the connection before the monitor 
threads are created so that would be nice to avoid if the connection hasn't 
failed.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 990326)
    Time Spent: 1h 50m  (was: 1h 40m)

> Prevent InactivityMonitor read check Timer leak when TCP connection fails
> -------------------------------------------------------------------------
>
>                 Key: AMQ-9392
>                 URL: https://issues.apache.org/jira/browse/AMQ-9392
>             Project: ActiveMQ Classic
>          Issue Type: Improvement
>            Reporter: Matt Pavlovich
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 6.3.0, 6.2.1
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Reported by Github user  Axel Sanguinetti 
> https://github.com/asanguinetti
> Description and PR provided: 
> https://github.com/apache/activemq/pull/1119



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to