[
https://issues.apache.org/jira/browse/ARTEMIS-5752?focusedWorklogId=990743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990743
]
ASF GitHub Bot logged work on ARTEMIS-5752:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/25 13:20
Start Date: 07/Nov/25 13:20
Worklog Time Spent: 10m
Work Description: GChuf commented on PR #6034:
URL:
https://github.com/apache/activemq-artemis/pull/6034#issuecomment-3502526860
Ah - I should have read the "text" section yesterday. Changing
.gitattributes to treat *.cmd as binary did the trick.
Will drop .gitattributes.
What do you think should be done with *.cmd files and their line endings?
Issue Time Tracking
-------------------
Worklog Id: (was: 990743)
Time Spent: 20m (was: 10m)
> Fix line endings
> ----------------
>
> Key: ARTEMIS-5752
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5752
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> An attempt to fix line endings for windows builds by changing
> maven-assembly-plugin's lineEnd settings and adding .gitattributes file.
> git --renormalize was also used to change encodings of some files to LF.
> note: I was not able to change .cmd files' encodings to CRLF in git's index
> ...
> current git ls-files --eol output:
> {code:java}
> git ls-files --eol *.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis-utility.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile.cmd
> i/lf w/crlf attr/text eol=crlf
> artemis-distribution/src/main/resources/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgrade/bin/artemis.cmd
> i/lf w/crlf attr/text eol=crlf
> tests/smoke-tests/src/main/filtered-resources/servers/windowsUpgradeETC/artemis.profile.cmd{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
