[
https://issues.apache.org/jira/browse/ARTEMIS-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-5745:
------------------------------------
Description:
I'd like to add support for exposing Jetty on Unix domain sockets.
The code in the PR is open to adjustments since this is just a "proof of
concept" so to say, and a lot of things are not as elegant as I'd like them to
be. I want to hear your opinions first.
There's 1 major change, and that's the removal of virtual hosts, and removal of
connector names.
>From what I understand, virtual host names should match connector names for
>jetty "routing" to work - but this only works for http and https connectors,
>not for unix sockets.
I had the issue of unix socket being created but the /console URL returning 404
- and the issue was resolved when I changed this code:
{code:java}
webapp.setVirtualHosts(new String[]{virtualHost}){code}
to this:
{code:java}
webapp.setVirtualHosts(null);{code}
I've had some help from AI, otherwise I couldn't find the source of the 404
"error":
_"Using null for virtual hosts makes the context respond to all connectors,
including Unix domain sockets."_
Since all connector names were added to virtualHost array, and all virtual
hosts were added to all contexts, the functionality should be the same after
this change ... Please correct me if I'm wrong.
You can test this PR by adding this into {{bootstrap.xml}}:
{code:xml}
<binding name="artemis" uri="unix:///tmp/jetty.sock">
<app name="console" url="console" war="console.war"/>
</binding>{code}
was:
I'd like to add support for unix sockets.
The code in the PR is open to adjustments, since this is just a "proof of
concept" so to say, and a lot of things are not as elegant as I'd like them to
be. I want to hear your opinions first.
There's 1 major change, and that's the removal of virtual hosts, and removal of
connector names.
>From what I understand, virtual host names should match connector names for
>jetty "routing" to work - but this only works for http and https connectors,
>not for unix sockets.
I had the issue of unix socket being created but the /console URL returning 404
- and the issue was resolved when I changed this code:
{code:java}
webapp.setVirtualHosts(new String[]{virtualHost}){code}
to this:
{code:java}
webapp.setVirtualHosts(null);{code}
I've had some help from AI, otherwise I couldn't find the source of the 404
"error":
_"Using null for virtual hosts makes the context respond to all connectors,
including Unix domain sockets."_
Since all connector names were added to virtualHost array, and all virtual
hosts were added to all contexts, the functionality should be the same after
this change ... Please correct me if I'm wrong.
You can test this PR by adding this into bootstrap.xml:
{code:java}
<binding name="artemis" uri="unix:///tmp/jetty.sock">
<app name="console" url="console" war="console.war"/>
</binding>{code}
> Add support for exposing Jetty on Unix domain socket
> ----------------------------------------------------
>
> Key: ARTEMIS-5745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5745
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I'd like to add support for exposing Jetty on Unix domain sockets.
> The code in the PR is open to adjustments since this is just a "proof of
> concept" so to say, and a lot of things are not as elegant as I'd like them
> to be. I want to hear your opinions first.
> There's 1 major change, and that's the removal of virtual hosts, and removal
> of connector names.
> From what I understand, virtual host names should match connector names for
> jetty "routing" to work - but this only works for http and https connectors,
> not for unix sockets.
> I had the issue of unix socket being created but the /console URL returning
> 404 - and the issue was resolved when I changed this code:
> {code:java}
> webapp.setVirtualHosts(new String[]{virtualHost}){code}
> to this:
> {code:java}
> webapp.setVirtualHosts(null);{code}
> I've had some help from AI, otherwise I couldn't find the source of the 404
> "error":
> _"Using null for virtual hosts makes the context respond to all connectors,
> including Unix domain sockets."_
> Since all connector names were added to virtualHost array, and all virtual
> hosts were added to all contexts, the functionality should be the same after
> this change ... Please correct me if I'm wrong.
> You can test this PR by adding this into {{bootstrap.xml}}:
> {code:xml}
> <binding name="artemis" uri="unix:///tmp/jetty.sock">
> <app name="console" url="console" war="console.war"/>
> </binding>{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
