[
https://issues.apache.org/jira/browse/ARTEMIS-4929?focusedWorklogId=991359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-991359
]
ASF GitHub Bot logged work on ARTEMIS-4929:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/25 16:06
Start Date: 12/Nov/25 16:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #6047:
URL: https://github.com/apache/activemq-artemis/pull/6047#discussion_r2518912719
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -1733,8 +1734,16 @@ public void acknowledge(final Transaction tx, final
MessageReference ref, final
if (AuditLogger.isMessageLoggingEnabled()) {
// it's possible for the consumer to be null (e.g. acking the
message administratively)
final ServerSession session = consumer != null ?
server.getSessionByID(consumer.getSessionID()) : null;
- final Subject subject = session == null ? null :
session.getRemotingConnection().getSubject();
- final String remoteAddress = session == null ? null :
session.getRemotingConnection().getRemoteAddress();
+ final Subject subject;
+ final String remoteAddress;
+ if (session == null) {
+ subject = new Subject();
+ subject.getPrincipals().add(new UserPrincipal("management"));
+ remoteAddress = "internal";
Review Comment:
Mostly still feel the same comment applies after the change, since you
changed 'management' to 'system' but then simultaneously changed 'internal' to
'management'. Personally I would avoid including the word management in this
case given its entirely separate from the the brokers management interfaces.
Could it just be blank given there is actually no address?
Or, more directly on the nose option, "expiry"?
Issue Time Tracking
-------------------
Worklog Id: (was: 991359)
Time Spent: 0.5h (was: 20m)
> Incorrect logging for anonymous user message acknowledgement events
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4929
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4929
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.35.0
> Reporter: Aleksandr Milovidov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When messages in the queue are expired, it is logged in the audit log with
> events:
> {noformat}
> AMQ601500: User admin(amq)@127.0.0.1:61979 sent a message CoreMessage ...
> AMQ601759: User [email protected]:61979 added acknowledgement of a message
> from TEST: ...
> AMQ601502: User [email protected]:61979 acknowledged message from TEST:
> ...{noformat}
> Source IP address and port in these events are the same like in previous
> events (in this example, send message event).
> How to reproduce:
> - create default Artemis instance
> - enable message audit logging in {{log4j2.properties}}
> - send one test message with 1 second expiry using 127.0.0.1 loopback address
> - wait some seconds for message expiry
> - send another test message with expiry using computer's IP address
> - wait some seconds for message expiry
> - check {{audit.log}} for message send and acknowledge events
> Example commands:
> {noformat}
> artemis producer --url=tcp://127.0.0.1:61616 --user=admin --password=admin
> --message-count=1 --msgttl=1000{noformat}
> {noformat}
> artemis producer --url=tcp://192.168.0.1:61616 --user=admin --password=admin
> --message-count=1 --msgttl=1000{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
