[
https://issues.apache.org/jira/browse/ARTEMIS-5750?focusedWorklogId=991786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-991786
]
ASF GitHub Bot logged work on ARTEMIS-5750:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/25 17:35
Start Date: 14/Nov/25 17:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6066:
URL: https://github.com/apache/activemq-artemis/pull/6066#discussion_r2528366847
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/settings/impl/DiskFullMessagePolicy.java:
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.settings.impl;
+
+public enum DiskFullMessagePolicy {
Review Comment:
Ohhhh... I see now!!!
checkMemory is validating if the message should block, before it enters into
paging...
I got confused with the page-limit...
you are adding a configuration option if the system should fail upon disk
full...
then it makes sense to have an extra configuration option...!!!!
I got this backwards before :)
sorry @jbertram / @iliya-gr
lets keep the separate setting.
Issue Time Tracking
-------------------
Worklog Id: (was: 991786)
Time Spent: 3h 20m (was: 3h 10m)
> Add an address disk-full-policy configuration parameter that will define the
> message policy when the disk space limit is reached.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5750
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5750
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Iliya Grushevskiy
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Implement an address configuration parameter disk-full-policy, that will
> DROP, FAIL or BLOCK producer message flow when disk limits are reached. By
> default, it will BLOCK to maintain the current behavior.
> Currently, if address paging is enabled the default behavior is to always
> BLOCK the producer. This can be an undesirable behavior for clients, which
> should fail quickly on any send failure and switch to another broker.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
