[
https://issues.apache.org/jira/browse/ARTEMIS-4767?focusedWorklogId=991795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-991795
]
ASF GitHub Bot logged work on ARTEMIS-4767:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/25 18:33
Start Date: 14/Nov/25 18:33
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #6050:
URL: https://github.com/apache/activemq-artemis/pull/6050#discussion_r2528519756
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2436,7 +2436,7 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
throw e;
}
- if (server.getConfiguration().isPopulateValidatedUser() && validatedUser
!= null) {
+ if (server.getConfiguration().isPopulateValidatedUser() && validatedUser
!= null && !validatedUser.equals(server.getConfiguration().getClusterUser())) {
Review Comment:
> The cluster user is the real validated user for the target broker.
Technically that is correct. However, as I understand it, the use-case for
adding validate-user to a message is to track who originally sent the message.
The fact that the message moved from one broker to another over a cluster
connection is really just an implementation detail, and I would argue that
we're leaking this information into the message when we shouldn't.
Furthermore, tracking the cluster-user doesn't really add meaningful
information because the cluster-user is extremely unlikely to change.
Issue Time Tracking
-------------------
Worklog Id: (was: 991795)
Time Spent: 1h 10m (was: 1h)
> Original JMSXUserID is lost on message redistribution
> -----------------------------------------------------
>
> Key: ARTEMIS-4767
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4767
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.33.0
> Reporter: Michael Desmedt
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> when {{populate-validated-user}} is set to true, in a clustered configuration:
> if both the producer and the consumer are on the same broker, when a message
> is sent with user1, consumed message contains property {{JMSXUserID:user1}}
> if the producer and the consumer are on different brokers in the same
> cluster, when a message is sent with user1, the consumed message contains
> property {{JMSXUserID:<value of <cluster-user>>}}
>
> initial validated-user value is lost.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
