[
https://issues.apache.org/jira/browse/ARTEMIS-5745?focusedWorklogId=992043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992043
]
ASF GitHub Bot logged work on ARTEMIS-5745:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/25 14:18
Start Date: 17/Nov/25 14:18
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #6027:
URL:
https://github.com/apache/activemq-artemis/pull/6027#issuecomment-3542077347
Do you plan on doing more testing? The current results aren't exactly
compelling.
Issue Time Tracking
-------------------
Worklog Id: (was: 992043)
Time Spent: 1h 40m (was: 1.5h)
> Add support for exposing Jetty on Unix domain socket
> ----------------------------------------------------
>
> Key: ARTEMIS-5745
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5745
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.44.0
> Reporter: Gašper Čefarin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I'd like to add support for exposing Jetty on Unix domain sockets.
> The code in the PR is open to adjustments since this is just a "proof of
> concept" so to say, and a lot of things are not as elegant as I'd like them
> to be. I want to hear your opinions first.
> There's 1 major change, and that's the removal of virtual hosts, and removal
> of connector names.
> From what I understand, virtual host names should match connector names for
> jetty "routing" to work - but this only works for http and https connectors,
> not for unix sockets.
> I had the issue of unix socket being created but the /console URL returning
> 404 - and the issue was resolved when I changed this code:
> {code:java}
> webapp.setVirtualHosts(new String[]{virtualHost}){code}
> to this:
> {code:java}
> webapp.setVirtualHosts(null);{code}
> I've had some help from AI, otherwise I couldn't find the source of the 404
> "error":
> _"Using null for virtual hosts makes the context respond to all connectors,
> including Unix domain sockets."_
> Since all connector names were added to virtualHost array, and all virtual
> hosts were added to all contexts, the functionality should be the same after
> this change ... Please correct me if I'm wrong.
> You can test this PR by adding this into {{bootstrap.xml}}:
> {code:xml}
> <binding name="artemis" uri="unix:///tmp/jetty.sock">
> <app name="console" url="console" war="console.war"/>
> </binding>{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
