[
https://issues.apache.org/jira/browse/ARTEMIS-5770?focusedWorklogId=992244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992244
]
ASF GitHub Bot logged work on ARTEMIS-5770:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/25 13:57
Start Date: 18/Nov/25 13:57
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #6081:
URL: https://github.com/apache/activemq-artemis/pull/6081#discussion_r2538324126
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:
##########
@@ -394,11 +393,11 @@ public String getRemoteAddress() {
@Override
public final String getLocalAddress() {
- SocketAddress address = channel.localAddress();
+ String address = SocketAddressUtil.toString(channel.localAddress());
if (address == null) {
return null;
}
- return "tcp://" + IPV6Util.encloseHost(address.toString());
Review Comment:
This change could affect the users who filter by localAddress when listing
connections, consumers, producers and sessions. Could you add a note for the
next release in the versions.adoc file?
Issue Time Tracking
-------------------
Worklog Id: (was: 992244)
Time Spent: 20m (was: 10m)
> Improve local address formatting
> --------------------------------
>
> Key: ARTEMIS-5770
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5770
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some contexts the "local address" for a connection is prefixed with {{/}}
> and in other contexts is is prefixed with {{tcp://}}. Both of these should be
> removed so that there's just a host & port.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
