[
https://issues.apache.org/jira/browse/AMQ-8525?focusedWorklogId=992937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992937
]
ASF GitHub Bot logged work on AMQ-8525:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/25 10:38
Start Date: 22/Nov/25 10:38
Worklog Time Spent: 10m
Work Description: jeanouii commented on PR #1541:
URL: https://github.com/apache/activemq/pull/1541#issuecomment-3566470786
Aside from a few tests where I had to make the data directory dynamic (so
parallel executions each get their own directory), the rest of the changes are
simply adding @Category on test classes that can safely run in parallel. I went
through the modules manually to identify which tests were compatible, which
took some time. Many of the remaining ones could be migrated as well, but they
need deeper refactoring, so they aren’t part of the “quick win” I was aiming
for here.
The rest is just Surefire configuration.
Regarding migrating to JUnit 5/6: I agree that @Category → @Tag and Surefire
<groups> → <includeTags> is straightforward. If your suggestion is to go that
route instead, I’m perfectly fine with it. Vintage is deprecated but still
available in JUnit 6, so it gives us some runway.
I also fully agree that most tests ultimately need to be modernized. Many
still inherit from TestCase, so we’ll need to add proper @Test annotations, use
before/after hooks, and switch to assertions for timeouts and exceptions. With
the current codebase, that’s a substantial amount of work. I know the community
is interested in pushing towards that modernization—which is great—but in the
meantime getting faster CI feedback (2–3 hours instead of ~7 hours) would
already be a big improvement.
What do you think?
Issue Time Tracking
-------------------
Worklog Id: (was: 992937)
Time Spent: 2h 50m (was: 2h 40m)
> Improve unit test exec times
> ----------------------------
>
> Key: AMQ-8525
> URL: https://issues.apache.org/jira/browse/AMQ-8525
> Project: ActiveMQ
> Issue Type: Task
> Reporter: Matt Pavlovich
> Priority: Major
> Fix For: 6.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> These 35 tests need optimization (take almost 2hrs):
> {noformat}
> Time Test Name
> 639.012 org.apache.activemq.bugs.TransactedStoreUsageSuspendResumeTest
> 342.786 org.apache.activemq.bugs.AMQ6815Test
> 316.349
> org.apache.activemq.store.kahadb.disk.journal.PreallocationJournalLatencyTest
> 311.467 org.apache.activemq.store.kahadb.JournalFdRecoveryTest
> 294.54 org.apache.activemq.bugs.AMQ6432Test
> 282.538 org.apache.activemq.bugs.MKahaDBTxVirtualTopicTest
> 280.548 org.apache.activemq.bugs.AMQ4485LowLimitTest
> 256.39
> org.apache.activemq.usecases.DurableSubsOfflineSelectorConcurrentConsumeIndexUseTest
> 234.467 org.apache.activemq.transport.MaxFrameSizeEnabledTest
> 233.287 org.apache.activemq.usecases.DuplexAdvisoryRaceTest
> 210.385 org.apache.activemq.bugs.AMQ5266SingleDestTest
> 209.125 org.apache.activemq.broker.JdbcXARecoveryBrokerNoCacheTest
> 184.016
> org.apache.activemq.usecases.TopicProducerDurableSubFlowControlTest
> 179.808 org.apache.activemq.bugs.AMQ7067Test
> 174.863 org.apache.activemq.broker.policy.AbortSlowAckConsumer0Test
> 153.73
> org.apache.activemq.broker.scheduler.memory.InMemoryJmsCronSchedulerTest
> 149.553 org.apache.activemq.usecases.BacklogNetworkCrossTalkTest
> 145.549
> org.apache.activemq.bugs.AMQ4485NetworkOfXBrokersWithNDestsFanoutTransactionTest
> 144.667 org.apache.activemq.usecases.DurableSubscriptionOffline1Test
> 134.543 org.apache.activemq.VirtualDestTest
> 133.98 org.apache.activemq.transport.mqtt.auto.MQTTAutoSslTest
> 133.686 org.apache.activemq.usecases.DurableSubscriptionOffline3Test
> 133.118 org.apache.activemq.transport.mqtt.MQTTSSLTest
> 132.917 org.apache.activemq.bugs.AMQ6459Test
> 130.673 org.apache.activemq.transport.mqtt.auto.MQTTAutoNioSslTest
> 129.692 org.apache.activemq.transport.mqtt.MQTTNIOSSLTest
> 128.402 org.apache.activemq.store.jdbc.XACompletionTest
> 124.509 org.apache.activemq.broker.policy.DiscardingDeadLetterPolicyTest
> 123.345
> org.apache.activemq.transport.mqtt.MQTTVirtualTopicSubscriptionsTest
> 120.432
> org.apache.activemq.usecases.RequestReplyTempDestRemovalAdvisoryRaceTest
> 118.287 org.apache.activemq.transport.mqtt.auto.MQTTAutoTest
> 118.042 org.apache.activemq.transport.mqtt.MQTTNIOTest
> 117.525 org.apache.activemq.transport.mqtt.auto.MQTTAutoNioTest
> 116.847 org.apache.activemq.transport.mqtt.MQTTTest
> 106.145 org.apache.activemq.store.kahadb.disk.index.ListIndexTest
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
