[
https://issues.apache.org/jira/browse/AMQ-9815?focusedWorklogId=995415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-995415
]
ASF GitHub Bot logged work on AMQ-9815:
---------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/25 16:30
Start Date: 09/Dec/25 16:30
Worklog Time Spent: 10m
Work Description: jeanouii commented on code in PR #1556:
URL: https://github.com/apache/activemq/pull/1556#discussion_r2603398183
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
Review Comment:
I find it more readable to do a return this.connector.getConnectUri() and
return null in the catch block.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
Review Comment:
Same as previous
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
+ } catch (Exception e) {}
+
+ return (publishableConnectURI != null ?
publishableConnectURI.toString() : null);
+ }
+
+ @Override
+ public String getBrokerInfoString() {
+ var tmpBrokerInfo = this.connector.getBrokerInfo();
+ return (tmpBrokerInfo != null ? tmpBrokerInfo.toString() : null);
Review Comment:
There is a getBrokerInfo() method already available
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ConnectorView.java:
##########
@@ -151,4 +153,82 @@ public boolean isAutoStart() {
public boolean isStarted() {
return this.connector.isStarted();
}
+
+ @Override
+ public String getConnectURI() {
+ URI tmpConnectUri = null;
+ try {
+ tmpConnectUri = this.connector.getConnectUri();
+ } catch (Exception e) {}
+ return (tmpConnectUri != null ? tmpConnectUri.toString() : null);
+ }
+
+ @Override
+ public String getPublishableConnectURI() {
+ URI publishableConnectURI = null;
+ try {
+ publishableConnectURI = this.connector.getPublishableConnectURI();
+ } catch (Exception e) {}
+
+ return (publishableConnectURI != null ?
publishableConnectURI.toString() : null);
+ }
+
+ @Override
+ public String getBrokerInfoString() {
+ var tmpBrokerInfo = this.connector.getBrokerInfo();
+ return (tmpBrokerInfo != null ? tmpBrokerInfo.toString() : null);
Review Comment:
if getBrokerInfo() can really return null, you probably could add a null
check above in other methods.
Issue Time Tracking
-------------------
Worklog Id: (was: 995415)
Time Spent: 20m (was: 10m)
> Update TransportConnector JMX attributes
> ----------------------------------------
>
> Key: AMQ-9815
> URL: https://issues.apache.org/jira/browse/AMQ-9815
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.3.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add several transport connector JMX attributes
> Mark 'connectionCount' as deprecated since that method naming style (no 'get'
> prefix) moves the connectionCount to be a JMX operation vs a JMX attribute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
