[ 
https://issues.apache.org/jira/browse/AMQ-8525?focusedWorklogId=995761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-995761
 ]

ASF GitHub Bot logged work on AMQ-8525:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Dec/25 09:37
            Start Date: 11/Dec/25 09:37
    Worklog Time Spent: 10m 
      Work Description: rmannibucau commented on code in PR #1541:
URL: https://github.com/apache/activemq/pull/1541#discussion_r2609871358


##########
activemq-mqtt/pom.xml:
##########
@@ -293,6 +294,70 @@
         </plugins>
       </build>
     </profile>
+    <profile>

Review Comment:
   profile is likely to not be ran when contributing/rebuilding so it is always 
a bad practise when setting up a test suite. Profiles are really for what can't 
run by default because it needs something special (latest nvidia gpu for ex to 
be trendy). There, there is no reason since it do run, it just needs another 
execution if you think it is worth splitting - my 2 cts would be I would make 
it working in the default execution to ensure a smooth integration in the IDE 
for contributors but this is more a habit/preference.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 995761)
    Time Spent: 6h 40m  (was: 6.5h)

> Improve unit test exec times
> ----------------------------
>
>                 Key: AMQ-8525
>                 URL: https://issues.apache.org/jira/browse/AMQ-8525
>             Project: ActiveMQ
>          Issue Type: Task
>            Reporter: Matt Pavlovich
>            Priority: Major
>             Fix For: 6.x
>
>          Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> These 35 tests need optimization (take almost 2hrs):
> {noformat}
> Time  Test Name
> 639.012       org.apache.activemq.bugs.TransactedStoreUsageSuspendResumeTest
> 342.786       org.apache.activemq.bugs.AMQ6815Test
> 316.349       
> org.apache.activemq.store.kahadb.disk.journal.PreallocationJournalLatencyTest
> 311.467       org.apache.activemq.store.kahadb.JournalFdRecoveryTest
> 294.54        org.apache.activemq.bugs.AMQ6432Test
> 282.538       org.apache.activemq.bugs.MKahaDBTxVirtualTopicTest
> 280.548       org.apache.activemq.bugs.AMQ4485LowLimitTest
> 256.39        
> org.apache.activemq.usecases.DurableSubsOfflineSelectorConcurrentConsumeIndexUseTest
> 234.467       org.apache.activemq.transport.MaxFrameSizeEnabledTest
> 233.287       org.apache.activemq.usecases.DuplexAdvisoryRaceTest
> 210.385       org.apache.activemq.bugs.AMQ5266SingleDestTest
> 209.125       org.apache.activemq.broker.JdbcXARecoveryBrokerNoCacheTest
> 184.016       
> org.apache.activemq.usecases.TopicProducerDurableSubFlowControlTest
> 179.808       org.apache.activemq.bugs.AMQ7067Test
> 174.863       org.apache.activemq.broker.policy.AbortSlowAckConsumer0Test
> 153.73        
> org.apache.activemq.broker.scheduler.memory.InMemoryJmsCronSchedulerTest
> 149.553       org.apache.activemq.usecases.BacklogNetworkCrossTalkTest
> 145.549       
> org.apache.activemq.bugs.AMQ4485NetworkOfXBrokersWithNDestsFanoutTransactionTest
> 144.667       org.apache.activemq.usecases.DurableSubscriptionOffline1Test
> 134.543       org.apache.activemq.VirtualDestTest
> 133.98        org.apache.activemq.transport.mqtt.auto.MQTTAutoSslTest
> 133.686       org.apache.activemq.usecases.DurableSubscriptionOffline3Test
> 133.118       org.apache.activemq.transport.mqtt.MQTTSSLTest
> 132.917       org.apache.activemq.bugs.AMQ6459Test
> 130.673       org.apache.activemq.transport.mqtt.auto.MQTTAutoNioSslTest
> 129.692       org.apache.activemq.transport.mqtt.MQTTNIOSSLTest
> 128.402       org.apache.activemq.store.jdbc.XACompletionTest
> 124.509       org.apache.activemq.broker.policy.DiscardingDeadLetterPolicyTest
> 123.345       
> org.apache.activemq.transport.mqtt.MQTTVirtualTopicSubscriptionsTest
> 120.432       
> org.apache.activemq.usecases.RequestReplyTempDestRemovalAdvisoryRaceTest
> 118.287       org.apache.activemq.transport.mqtt.auto.MQTTAutoTest
> 118.042       org.apache.activemq.transport.mqtt.MQTTNIOTest
> 117.525       org.apache.activemq.transport.mqtt.auto.MQTTAutoNioTest
> 116.847       org.apache.activemq.transport.mqtt.MQTTTest
> 106.145       org.apache.activemq.store.kahadb.disk.index.ListIndexTest
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to