[
https://issues.apache.org/jira/browse/AMQ-9820?focusedWorklogId=996715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996715
]
ASF GitHub Bot logged work on AMQ-9820:
---------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/25 14:56
Start Date: 17/Dec/25 14:56
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1564:
URL: https://github.com/apache/activemq/pull/1564#discussion_r2627394720
##########
activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/PooledConnectionSecurityExceptionTest.java:
##########
@@ -134,8 +134,12 @@ public void testFailureGetsNewConnectionOnRetry() throws
Exception {
@Override
public boolean isSatisified() throws Exception {
- return connection1.getConnection() !=
- ((PooledConnection)
pooledConnFact.createConnection("invalid", "credentials")).getConnection();
+ PooledConnection newConnection = (PooledConnection)
pooledConnFact.createConnection("invalid", "credentials");
Review Comment:
How about try-with-resources here?
##########
activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/PooledConnectionSecurityExceptionTest.java:
##########
@@ -232,8 +236,12 @@ public void testFailoverWithInvalidCredentials() throws
Exception {
@Override
public boolean isSatisified() throws Exception {
- return connection1.getConnection() !=
- ((PooledConnection)
pooledConnFact.createConnection("invalid", "credentials")).getConnection();
+ PooledConnection newConnection = (PooledConnection)
pooledConnFact.createConnection("invalid", "credentials");
Review Comment:
same.. t-w-r here?
Issue Time Tracking
-------------------
Worklog Id: (was: 996715)
Time Spent: 20m (was: 10m)
> Closed connections leaked in the connection pool
> ------------------------------------------------
>
> Key: AMQ-9820
> URL: https://issues.apache.org/jira/browse/AMQ-9820
> Project: ActiveMQ
> Issue Type: Bug
> Components: ConnectionPool
> Reporter: Jean-Louis Monteiro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When using reconnectOnException for the PooledConnectionFactory, it seems
> that closed connections (on exception) remain in the pool due to wrong
> validation rules
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
