[
https://issues.apache.org/jira/browse/AMQ-9806?focusedWorklogId=1004595&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1004595
]
ASF GitHub Bot logged work on AMQ-9806:
---------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/26 13:44
Start Date: 11/Feb/26 13:44
Worklog Time Spent: 10m
Work Description: jeanouii commented on code in PR #1535:
URL: https://github.com/apache/activemq/pull/1535#discussion_r2793365779
##########
activemq-unit-tests/src/test/java/org/apache/activemq/store/jdbc/h2/H2DB.java:
##########
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.store.jdbc.h2;
+
+import javax.sql.DataSource;
+import org.h2.jdbcx.JdbcDataSource;
+
+import java.io.IOException;
+
+public class H2DB {
+
+ public static DataSource createDataSource(String db) throws IOException {
+ var ds = new JdbcDataSource();
+ ds.setURL(createURL(db));
+ ds.setUser(getUser());
+ ds.setPassword(getPassword());
+ return ds;
+ }
+
+ public static String createURL(String db) {
+ return "jdbc:h2:./target/h2-db/" + db + "/" + db +
"-h2.db;DB_CLOSE_DELAY=-1";
Review Comment:
Good to have a database per test so we can later use parallelism if needed.
##########
activemq-jdbc-store/src/main/java/org/apache/activemq/store/jdbc/adapter/H2JDBCAdapter.java:
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.store.jdbc.adapter;
+
+import org.apache.activemq.store.jdbc.Statements;
+
+/**
+ *
+ * @org.apache.xbean.XBean element="h2-jdbc-adapter"
+ */
+public class H2JDBCAdapter extends BytesJDBCAdapter {
+
+ @Override
+ public void setStatements(Statements statements) {
+ statements.setBinaryDataType("BLOB");
+ super.setStatements(statements);
+ }
+
+ @Override
+ public String limitQuery(String query) {
Review Comment:
I had a PR open to use the limitQuery everywhere because it's not in the
default adapter (super class). Just an FYI
Issue Time Tracking
-------------------
Worklog Id: (was: 1004595)
Remaining Estimate: 0h
Time Spent: 10m
> Add H2 database support
> -----------------------
>
> Key: AMQ-9806
> URL: https://issues.apache.org/jira/browse/AMQ-9806
> Project: ActiveMQ
> Issue Type: Task
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
