GitHub user scnakandala opened a pull request:
https://github.com/apache/airavata-php-gateway/pull/4
Wrapping Airavata and WSIS code as laravel library component and as service
providers
This pull request basically undo my previous pull request of wrapping WSIS
code as a separate package.
I found that defining our own helper classes as packages is not the correct
way to wrap the code.
For example if we want to publish them they has to be first class
repositories itself and also this end up generating several configuration files
for each package which is problematic. This works for Auth0 because they are
providing packages to use by other people. The advantages that I saw using
package approach was the ability to define them as Service Providers and use
the laravel builtin support. For example we can simply call them in any part of
the code without including the class or creating an object explicitly eg.
WSIS::authenticate( , ).
Later I found that we can get the same functionality while putting the code
in the libraries and hence rolled back to that approach.
Now any Airavata API method or IS method can be directly used by calling
WSIS:: or Airavata::
To unify the property files I have added a php file named pga_config.php in
the app/config directory.
I have put all the IS configurations and only some of Airavata
configurations to the file because I am not sure what these properties mean in
the application context. Any property value can be read any where in the
application by simply calling
Config::get('pga_config.airavata')['airavata-timeout'] etc. By following this
way we don't need to read the ini file here and there and it is the recommended
way to store and retrieve configurations in laravel. After moving all
configuration to pga_config.php we can remove ini files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scnakandala/airavata-php-gateway master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata-php-gateway/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 3ca02155c67493ff295638e5fc2a2d74a0f0d4cb
Author: Supun Nakandala <[email protected]>
Date: 2015-05-09T08:24:23Z
wrapping Airavata and WSIS code as laravel library component and service
providers
commit e1a1024f372bf485ccaa7e68efd00cb3bd33f44b
Author: Supun Nakandala <[email protected]>
Date: 2015-05-09T08:45:37Z
Adding missing files
commit 01d2420de3f349b1f6f1c6888fed089fa026149d
Author: Supun Nakandala <[email protected]>
Date: 2015-05-09T08:47:17Z
Adding missing files
commit c1174e1e7716c8fa1d11406bb77edfa7c6791857
Author: Supun Nakandala <[email protected]>
Date: 2015-05-09T08:57:15Z
Correcting the wrong API method invocation in Wsis.php
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
