[ https://issues.apache.org/jira/browse/AIRAVATA-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637091#comment-15637091 ]
ASF GitHub Bot commented on AIRAVATA-2163: ------------------------------------------ GitHub user anujbhan opened a pull request: https://github.com/apache/airavata/pull/74 AIRAVATA-2163: Optimising the cred store data model This pull request resolves, https://issues.apache.org/jira/browse/AIRAVATA-2163 You can merge this pull request into a Git repository by running: $ git pull https://github.com/anujbhan/airavata optimise-cred-store Alternatively you can review and apply these changes as the patch at: https://github.com/apache/airavata/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 ---- commit 6c5f6db6f6c235c5c3f78b35238328cb387ed385 Author: Anuj Bhandar <bhandar.a...@gmail.com> Date: 2016-11-04T17:26:32Z AIRAVATA-2163: Optimising the cred store data model ---- > optimize credential store data models > ------------------------------------- > > Key: AIRAVATA-2163 > URL: https://issues.apache.org/jira/browse/AIRAVATA-2163 > Project: Airavata > Issue Type: Improvement > Components: Airavata API > Environment: Development > Reporter: Anuj Bhandar > Assignee: Anuj Bhandar > Labels: GATask > > This improvement is based on the following Pull request : > https://github.com/apache/airavata/pull/54. > **Improvements agreed upon :** > Followings are few suggestions to improve your pull request. > * We can do this in a better way by adding generic API method(to > AiravataAPIServer) like "getAllCredentialSummary" instead of adding API > method for each credential types eg: "getAllGatewaySSHPubKeysSummary" which > will return all the credential summary for that particular gatewayId. You may > be able to remove few redundant methods from Airavata API server. > * Let's introduced one credential summary struct to all credential types, > how we differentiate is we have credential type enum field( SSH, PASSWD, CERT > etc ) in the credential summary thrift struct. > * Move credential data model thrift file to data model directory and > merge credential summary thrift file with it. > * Credential stubs still have date fields in generated thrift files, not > because your changes, but we need to fix it so remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)