[
https://issues.apache.org/jira/browse/AIRAVATA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716111#comment-15716111
]
ASF GitHub Bot commented on AIRAVATA-2077:
------------------------------------------
GitHub user machristie opened a pull request:
https://github.com/apache/airavata-php-gateway/pull/51
AIRAVATA-2077 add some validation for user role changing
Some improvements to role management UI
* when user-pending role is added, remove the other roles
* don't allow removing the last role
* other minor bug fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/machristie/airavata-php-gateway
AIRAVATA-2077-add-some-validation-for-user-role-changing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata-php-gateway/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 2bc99dcd29b119f1be0e692f02ce7e2bbb47f796
Author: Marcus Christie <[email protected]>
Date: 2016-12-01T16:02:04Z
AIRAVATA-2077 When user-pending role added, remove other roles
commit f5f131c807c41702c729c5aa8f849cd89bd19477
Author: Marcus Christie <[email protected]>
Date: 2016-12-02T19:52:29Z
AIRAVATA-2077 Don't allow removing last role
Also fixed some UI bugs
* display spinner when adding a role
* only register the remove role button listener once
----
> Add some validation for user-role changing
> ------------------------------------------
>
> Key: AIRAVATA-2077
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2077
> Project: Airavata
> Issue Type: Bug
> Reporter: Lahiru Gunathilake
> Assignee: Marcus Christie
>
> Admin can remove user role from pending to nothing. I think we should not let
> this because no user-role is not a valid state, either user has to be removed
> or add a meaningful role (disable).
> Main purpose of this issue is to add validation for user-roles. We saw this
> mistake happen in new admin in phasta gateway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
