[ 
https://issues.apache.org/jira/browse/AIRAVATA-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256523#comment-16256523
 ] 

Sachin Kariyattin edited comment on AIRAVATA-2591 at 11/17/17 5:51 AM:
-----------------------------------------------------------------------

[~smarru] [~tilaks26]
Currently the deleteGroup() or addUsersToGroup() CPI methods do not accept any 
parameters related to which user is trying to delete the group or add new users 
to the group. Now, if I want to make sure that only the OWNER is able to delete 
the group or ADMIN can add/remove users to the group then I need to make 
changes to the method definitions of these CPI methods by adding an additional 
parameter (ownerId or adminId). But if I make these changes, the existing 
clients that are using these services will be affected.

Do I need to make the above changes in the CPI methods or the clients should 
handle these using the new methods that I have added like hasAdminAccess() and 
hasOwnerAccess() (pls refer my pull request for these methods)



was (Author: sachin kariyattin):

Currently the deleteGroup() or addUsersToGroup() CPI methods do not accept any 
parameters related to which user is trying to delete the group or add new users 
to the group. Now, if I want to make sure that only the OWNER is able to delete 
the group or ADMIN can add/remove users to the group then I need to make 
changes to the method definitions of these CPI methods by adding an additional 
parameter (ownerId or adminId). But if I make these changes, the existing 
clients that are using these services will be affected.

Do I need to make the above changes in the CPI methods or the clients should 
handle these using the new methods that I have added like hasAdminAccess() and 
hasOwnerAccess()(pull request https://github.com/apache/airavata/pull/141).



> Add group roles capabilities to Groups 
> ---------------------------------------
>
>                 Key: AIRAVATA-2591
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2591
>             Project: Airavata
>          Issue Type: New Feature
>            Reporter: Suresh Marru
>            Assignee: Sachin Kariyattin
>
> Currently, the group members do not have fine-grained roles so only the owner 
> can add users to this group. 
> It will be better to add group-member-roles:
> * The owner who creates the group initially. This ownership should be 
> transferable to a different user. Only owners should be allowed to delete the 
> groups. 
> * admin - a user role which will allow to add more users or remove users from 
> the group. 
> * user - all users added to the group are by default in this role. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to