[
https://issues.apache.org/jira/browse/AIRAVATA-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343834#comment-16343834
]
ASF GitHub Bot commented on AIRAVATA-2652:
------------------------------------------
machristie commented on a change in pull request #164: [AIRAVATA-2652] Remove
registry-core dependency on orchestrator and gfac modules
URL: https://github.com/apache/airavata/pull/164#discussion_r164530073
##########
File path:
modules/orchestrator/orchestrator-service/src/main/java/org/apache/airavata/orchestrator/server/OrchestratorServerHandler.java
##########
@@ -187,16 +182,18 @@ public boolean launchExperiment(String experimentId,
String gatewayId) throws TE
} else {
log.error("Could not find a replica for the URI " + pi.getValue());
}
- } catch
(ReplicaCatalogException e) {
-
log.error(e.getMessage(), e);
- }
- } else if
(pi.getType().equals(DataType.URI_COLLECTION) &&
pi.getValue().contains("airavata-dp://")) {
+ } catch
(RegistryServiceException e) {
+ e.printStackTrace();
Review comment:
Please wrap these in RuntimeException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove registry-core dependency on orchestrator and gfac modules
> ----------------------------------------------------------------
>
> Key: AIRAVATA-2652
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2652
> Project: Airavata
> Issue Type: Improvement
> Components: Airavata Orchestrator, GFac, Registry API
> Reporter: Sachin Kariyattin
> Assignee: Sachin Kariyattin
> Priority: Major
> Fix For: 0.18
>
>
> Refactor orchestrator and gfac modules to use registry-api instead of the
> existing registry-core dependency
> * Some of the Experiment Catalog methods used by the orchestrator and gfac
> are not present in the RegistryServerHandler.
> ex: _experimentCatalog.add(ExpCatChildDataType.EXPERIMENT_ERROR, details,
> experimentId);_
> Some new methods related to experiment (ERROR, TASK, PROCESS etc) need to be
> created in the RegistryServerHandler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
