[ 
https://issues.apache.org/jira/browse/AIRAVATA-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367410#comment-16367410
 ] 

ASF GitHub Bot commented on AIRAVATA-2662:
------------------------------------------

machristie commented on a change in pull request #168: [AIRAVATA-2662] Adding 
Migrator class to create everyone group in all domains
URL: https://github.com/apache/airavata/pull/168#discussion_r168775864
 
 

 ##########
 File path: 
modules/sharing-registry/sharing-registry-server/src/main/java/org/apache/airavata/sharing/registry/server/SharingRegistryServerHandler.java
 ##########
 @@ -277,7 +277,9 @@ public String createGroup(UserGroup group) throws 
SharingRegistryException, TExc
             group.setUpdatedTime(System.currentTimeMillis());
             (new UserGroupRepository()).create(group);
 
-            addUsersToGroup(group.domainId, Arrays.asList(group.ownerId), 
group.groupId);
+            if(group.ownerId != null)
 
 Review comment:
   Sneha, instead of having no owner, let's make the owner an argument to the 
migration script like you did in the other pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> One-Time Migration to Create the "everyone" Group for all Domains
> -----------------------------------------------------------------
>
>                 Key: AIRAVATA-2662
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2662
>             Project: Airavata
>          Issue Type: Improvement
>            Reporter: Sneha Tilak
>            Assignee: Sneha Tilak
>            Priority: Major
>
> One-time migration to create and populate the “everyone” group for all 
> existing domains and share all the existing application deployments with the 
> group.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to