[
https://issues.apache.org/jira/browse/AIRAVATA-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403205#comment-16403205
]
ASF GitHub Bot commented on AIRAVATA-2607:
------------------------------------------
DImuthuUpe commented on a change in pull request #183: [AIRAVATA-2607] Change
all thrift clients to use ThriftClientPool
URL: https://github.com/apache/airavata/pull/183#discussion_r175244469
##########
File path:
airavata-services/profile-service/profile-service-server/src/main/java/org/apache/airavata/service/profile/handlers/UserProfileServiceHandler.java
##########
@@ -111,11 +122,15 @@ public boolean updateUserProfile(AuthzToken authzToken,
UserProfile userProfile)
}
private Runnable getIAMUserProfileUpdater(AuthzToken authzToken,
UserProfile userProfile) throws UserProfileServiceException {
- IamAdminServices.Client iamAdminServicesClient =
getIamAdminServicesClient();
+ IamAdminServices.Client iamAdminServicesClient =
iasClientPool.getResource();
return () -> {
try {
iamAdminServicesClient.updateUserProfile(authzToken,
userProfile);
+ iasClientPool.returnResource(iamAdminServicesClient);
} catch (TException e) {
+ if (iamAdminServicesClient != null) {
Review comment:
add an error log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change all thrift clients to use ThriftClientPool
> -------------------------------------------------
>
> Key: AIRAVATA-2607
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2607
> Project: Airavata
> Issue Type: Improvement
> Reporter: Suresh Marru
> Assignee: Sachin Kariyattin
> Priority: Major
>
> Currently, the API server uses ThriftClientPool but all other thrift servers
> use a regular client.
> We probably should move the current ThriftClientPool into the commons library
> and have all thrift servers use this instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
