[
https://issues.apache.org/jira/browse/AIRAVATA-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413915#comment-16413915
]
ASF GitHub Bot commented on AIRAVATA-2619:
------------------------------------------
machristie commented on a change in pull request #182: [AIRAVATA-2619]
Refactoring App Catalog implementation - StorageResource
URL: https://github.com/apache/airavata/pull/182#discussion_r177090924
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/entities/appcatalog/StorageInterfaceEntity.java
##########
@@ -20,26 +20,29 @@
*/
package org.apache.airavata.registry.core.entities.appcatalog;
-import javax.persistence.Column;
-import javax.persistence.EmbeddedId;
-import javax.persistence.Entity;
-import javax.persistence.Table;
+import javax.persistence.*;
import java.io.Serializable;
import java.sql.Timestamp;
/**
* The persistent class for the storage_interface database table.
*/
@Entity
-@Table(name = "storage_interface")
+@Table(name = "STORAGE_INTERFACE")
+@IdClass(StorageInterfacePK.class)
public class StorageInterfaceEntity implements Serializable {
private static final long serialVersionUID = 1L;
- @EmbeddedId
- private StorageInterfacePK id;
+ @Id
+ @Column(name="STORAGE_RESOURCE_ID")
+ private String storageResourceId;
+
+ @Id
+ @Column(name="DATA_MOVEMENT_INTERFACE_ID")
+ private String dataMovementInterfaceId;
@Column(name = "CREATION_TIME")
- private Timestamp creationTime;
+ private long creationTime;
Review comment:
The database type is TIMESTAMP, will this map with the existing schema? It
would be good if we could have the entity mapping to handle long to timestamp
mapping. This is also related to this bug:
https://issues.apache.org/jira/browse/AIRAVATA-2428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring App Catalog implementation
> --------------------------------------
>
> Key: AIRAVATA-2619
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2619
> Project: Airavata
> Issue Type: Sub-task
> Reporter: Sachin Kariyattin
> Assignee: Sachin Kariyattin
> Priority: Major
>
> The app catalog module contains the following Impl classes.
> {quote}ApplicationDeploymentImpl
> ApplicationInterfaceImpl
> ComputeResourceImpl
> GwyResourceProfileImpl
> StorageResourceImpl
> UsrResourceProfileImpl
> {quote}
> This task involves creating a repository class for app catalog and include
> all the methods from the Impl classes mentioned above. As a modular approach
> is being followed, to start of, only methods GwyResourceProfileImpl will be
> considered. So the RegistryServiceHandler methods only with respect to
> GwyResourceProfileImpl will be modified. Subsequently all methods related to
> app catalog will be refactored.
> *Progress*:
> * Implemeted GatewayResourceProfileRepository.
> * Implemented ComputeResourceRepository.
> * Implemented StorageResourceRepository.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
