[
https://issues.apache.org/jira/browse/AIRAVATA-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414817#comment-16414817
]
ASF GitHub Bot commented on AIRAVATA-2719:
------------------------------------------
machristie commented on a change in pull request #187: [AIRAVATA-2719]
Refactoring Replica Catalog Implementation
URL: https://github.com/apache/airavata/pull/187#discussion_r177274122
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/utils/JPAUtil/RepCatalogJPAUtils.java
##########
@@ -0,0 +1,81 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.airavata.registry.core.utils.JPAUtil;
+
+import org.apache.airavata.common.exception.ApplicationSettingsException;
+import org.apache.airavata.common.utils.ServerSettings;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.persistence.*;
+import java.util.HashMap;
+import java.util.Map;
+
+public class RepCatalogJPAUtils {
+ private final static Logger logger =
LoggerFactory.getLogger(RepCatalogJPAUtils.class);
+
+ private static final String PERSISTENCE_UNIT_NAME = "replicacatalog_data";
+ private static final String REPLICACATALOG_JDBC_DRIVER =
"replicacatalog.jdbc.driver";
+ private static final String REPLICACATALOG_JDBC_URL =
"replicacatalog.jdbc.url";
+ private static final String REPLICACATALOG_JDBC_USER =
"replicacatalog.jdbc.user";
+ private static final String REPLICACATALOG_JDBC_PWD =
"replicacatalog.jdbc.password";
+ private static final String REPLICACATALOG_VALIDATION_QUERY =
"replicacatalog.validationQuery";
+
+ @PersistenceUnit(unitName="replicacatalog_data")
Review comment:
Can you use `PERSISTENCE_UNIT_NAME` here and on line 44?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring Replica Catalog
> ---------------------------
>
> Key: AIRAVATA-2719
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2719
> Project: Airavata
> Issue Type: Improvement
> Components: Registry API
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
