DImuthuUpe commented on a change in pull request #1: NIO based file transport implementation URL: https://github.com/apache/airavata-mft/pull/1#discussion_r314576250
########## File path: core/src/main/java/org/apache/airavata/mft/core/bufferedImpl/AbstractConnector.java ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.airavata.mft.core.bufferedImpl; + +import org.apache.airavata.mft.core.api.Connector; +import org.apache.airavata.mft.core.api.SinkConnector; +import org.apache.airavata.mft.core.api.SourceConnector; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.nio.channels.Channel; +import java.util.concurrent.ConcurrentHashMap; + +/** + * Common class for {@link SinkConnector} and {@link SourceConnector} implementations + * This overrides closeChannel method and release all resources allocated to releasing channel + */ +public abstract class AbstractConnector implements Connector { + ConcurrentHashMap<Channel, Object> channelMap = new ConcurrentHashMap<>(); + + @Override + public void closeChannel(Channel channel) throws ConnectorException { + OutChannel outChannel; + InChannel inChannel; + + try { + if (channelMap.get(channel) instanceof OutputStream) { + outChannel = (OutChannel) channelMap.get(channel); + if (outChannel != null) { + outChannel.closeChannel(); + channelMap.remove(channel); + } + + } else if (channelMap.get(channel) instanceof InputStream) { + inChannel = (InChannel) channelMap.get(channel); + if (inChannel != null) { + inChannel.closeChannel(); + channelMap.remove(channel); + } + } + + } catch (IOException e) { + throw new ConnectorException("Error occurred while closing stream", e); + } + + } + + /** + * Cache the operating channel + * @param channel + * @param obj + */ + public void cacheChannel(Channel channel, Object obj) { + channelMap.put(channel, obj); + } + + + /** + * get the channel + * @param channel + * @return + */ + public Object getConnectorChannel(Channel channel) { Review comment: What could be the edge cases of channels getting invalidated / timed out? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
