[ 
https://issues.apache.org/jira/browse/AIRAVATA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979316#comment-16979316
 ] 

Marcus Christie edited comment on AIRAVATA-3268 at 11/21/19 6:44 PM:
---------------------------------------------------------------------

It appears however, that a default value for a required data field isn't 
automatically applied if it was never set.

{quote}
What is the purpose of specifying a default value for a “required” field?

To allow the structure to be fully valid even if deserialization didn't find 
the corresponding value on the wire? The C++ code is not consistent with it: if 
you try to deserialize a blob, which does not contain the value of a required 
field, the decoder will throw INVALID_DATA exception. 
{quote}

http://lionet.info/asn1c/blog/2010/07/18/thrift-semantics/

So it is possible that overridebyAiravata isn't getting set or copied onto the 
ComputeResourcePreference instance. The instance's 
{{isSetOverridebyAiravata()}} would be false even though the instance would 
have a default value of true for overridebyAiravata.


was (Author: marcuschristie):
It appears however, that a default value for a required data field isn't 
automatically applied if it was never set.

{blockquote}
What is the purpose of specifying a default value for a “required” field?

To allow the structure to be fully valid even if deserialization didn't find 
the corresponding value on the wire? The C++ code is not consistent with it: if 
you try to deserialize a blob, which does not contain the value of a required 
field, the decoder will throw INVALID_DATA exception. 
{blockquote}
http://lionet.info/asn1c/blog/2010/07/18/thrift-semantics/

So it is possible that overridebyAiravata isn't getting set or copied onto the 
ComputeResourcePreference instance. The instance's 
{{isSetOverridebyAiravata()}} would be false even though the instance would 
have a default value of true for overridebyAiravata.

> BUG: The input file name cannot be changed using value field content in 
> application interface
> ---------------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-3268
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-3268
>             Project: Airavata
>          Issue Type: Sub-task
>          Components: Django Portal
>    Affects Versions: 0.18
>            Reporter: Eroma
>            Assignee: Marcus Christie
>            Priority: Critical
>             Fix For: 0.19
>
>
> 1. When creating application inputs in Interface tab user can have the 
> uploading file name changed to the value given in "Value" field.
> 2. This new assigned name will be the one that get added to the job script as 
> well as the name of the file when the file is in the compute resource working 
> directory.
> h5. TODO
> - [x] model/db changes
> - [x] db migration script to copy input.value to input.overrideFilename
> - [ ] Django frontend changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to