DImuthuUpe commented on pull request #28:
URL: https://github.com/apache/airavata-mft/pull/28#issuecomment-777925941


   @machristie This is an intentional change. There are 2 overloaded methods 
for getDirectoryResourceMetadata 
   
   public DirectoryResourceMetadata getDirectoryResourceMetadata(String 
resourceId, String credentialToken)
   public DirectoryResourceMetadata getDirectoryResourceMetadata(String 
storageId, String resourcePath, String credentialToken)
   
   The first one is when you have a resource registered in the resource 
service. The second one is when you don't have a resource registered but you 
need to list files. I came up with the second one to avoid the overhead of 
registering resources for each storage but I see some possible issues with 
authorization. Maybe we need to change it back to 
   
   public DirectoryResourceMetadata getDirectoryResourceMetadata(String 
parentResourceId, String resourcePath, String credentialToken)
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to