[ 
https://issues.apache.org/jira/browse/AIRAVATA-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304486#comment-17304486
 ] 

ASF subversion and git services commented on AIRAVATA-3415:
-----------------------------------------------------------

Commit 8b0a93a37a1ad095c2d7919eb9c4216e15f54655 in airavata-django-portal's 
branch refs/heads/develop from Marcus Christie
[ https://gitbox.apache.org/repos/asf?p=airavata-django-portal.git;h=8b0a93a ]

AIRAVATA-3415 Fix bug loading app module when app has been deleted


> Don't require application interface to exist to load experiment 
> summary/statistics views
> ----------------------------------------------------------------------------------------
>
>                 Key: AIRAVATA-3415
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-3415
>             Project: Airavata
>          Issue Type: Bug
>          Components: Django Portal
>            Reporter: Marcus Christie
>            Assignee: Marcus Christie
>            Priority: Major
>
> This error
> {code}
> local variable 'applicationModule' referenced before assignment
> {code}
> in views.py: FullExperimentViewSet.get_instance:
> {code}
>         full_experiment = serializers.FullExperiment(
>             experimentModel,
>             project=project,
>             outputDataProducts=outputDataProducts,
>             inputDataProducts=inputDataProducts,
>             applicationModule=applicationModule,
>             computeResource=compute_resource,
>             jobDetails=job_details,
>             outputViews=exp_output_views)
> {code}
> And the problem appears to come from:
> {code}
>         try:
>             if applicationInterface is not None:
>                 appModuleId = applicationInterface.applicationModules[0]
>                 applicationModule = self.request.airavata_client \
>                     .getApplicationModule(self.authz_token, appModuleId)
>             else:
>                 log.warning(
>                     "Cannot log application model since app interface failed 
> to load")
>         except Exception:
>             log.exception("Failed to load app interface/module")
>             applicationModule = None
> {code}
> The applicationModule is never initialized to None in the else block above.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to