Jayancv commented on code in PR #68:
URL: https://github.com/apache/airavata-mft/pull/68#discussion_r1066049415
##########
transport/gcp-transport/src/main/java/org/apache/airavata/mft/transport/gcp/GCSMetadataCollector.java:
##########
@@ -19,131 +19,224 @@
import com.google.api.gax.paging.Page;
import com.google.cloud.storage.Blob;
+import com.google.cloud.storage.Bucket;
import com.google.cloud.storage.Storage;
import com.google.auth.oauth2.ServiceAccountCredentials;
import com.google.cloud.storage.StorageOptions;
+
import org.apache.airavata.mft.agent.stub.*;
import org.apache.airavata.mft.core.api.MetadataCollector;
import org.apache.airavata.mft.credential.stubs.gcs.GCSSecret;
import org.apache.airavata.mft.resource.stubs.gcs.storage.GCSStorage;
+import java.io.File;
import java.security.PrivateKey;
import java.time.temporal.ChronoField;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
-public class GCSMetadataCollector implements MetadataCollector {
+public class GCSMetadataCollector implements MetadataCollector
+{
boolean initialized = false;
private GCSStorage gcsStorage;
private GCSSecret gcsSecret;
@Override
- public void init(StorageWrapper storage, SecretWrapper secret) {
+ public void init( StorageWrapper storage, SecretWrapper secret )
+ {
this.gcsStorage = storage.getGcs();
this.gcsSecret = secret.getGcs();
this.initialized = true;
}
- private void checkInitialized() {
- if (!initialized) {
- throw new IllegalStateException("GCS Metadata Collector is not
initialized");
+ private void checkInitialized()
Review Comment:
Hope the current version is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
