machristie commented on code in PR #29:
URL:
https://github.com/apache/airavata-data-catalog/pull/29#discussion_r1162022421
##########
data-catalog-api/server/src/main/java/org/apache/airavata/datacatalog/api/sharing/SharingManagerImpl.java:
##########
@@ -89,8 +112,29 @@ public void initialize(String tenantId) throws
SharingException {
}
@Override
- public UserEntity resolveUser(UserInfo userInfo) {
- return null;
+ public UserEntity resolveUser(UserInfo userInfo) throws SharingException {
+ try (UserManagementClient userManagementClient =
custosClientProvider.getUserManagementClient()) {
Review Comment:
This is good but it should first check the database (UserRepository) to see
if the user already exists or not. Then it only needs to make the Custos API
call if it doesn't exist locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
