lahirujayathilake commented on code in PR #464:
URL: https://github.com/apache/airavata/pull/464#discussion_r2014985775
##########
modules/ide-integration/src/main/containers/docker-compose.yml:
##########
@@ -1,18 +1,19 @@
version: '3'
services:
keycloak:
- image: jboss/keycloak:2.5.4.Final
+ image: quay.io/keycloak/keycloak:24.0.0
environment:
- - KEYCLOAK_USER=admin
- - KEYCLOAK_PASSWORD=admin
+ - KEYCLOAK_ADMIN=admin
+ - KEYCLOAK_ADMIN_PASSWORD=admin
ports:
- - "18080:8080"
+ - "8080:8080"
Review Comment:
better to keep 18080
##########
modules/ide-integration/src/main/containers/docker-compose.yml:
##########
@@ -21,9 +22,9 @@ services:
- MYSQL_PASSWORD=123456
volumes:
- ./database_scripts/init:/docker-entrypoint-initdb.d
- - ./database_data:/var/lib/mysql
+ - db-data:/var/lib/mysql
Review Comment:
keep the docker volume but rename it to `database_data`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@airavata.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
