[ 
https://issues.apache.org/jira/browse/AIRAVATA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18079759#comment-18079759
 ] 

ASF subversion and git services commented on AIRAVATA-3972:
-----------------------------------------------------------

Commit 6cd5f3ce25eb203e720a2d5b266ac5f9e8ee6f47 in airavata-custos's branch 
refs/heads/signer-service from jayvenn21
[ https://gitbox.apache.org/repos/asf?p=airavata-custos.git;h=6cd5f3ce2 ]

AIRAVATA-3972: fix malformed JSON in Vault local config

The VAULT_LOCAL_CONFIG JSON string had a misplaced closing brace that
left the "ui": true property outside the JSON object, causing it to
be silently ignored by Vault on container startup.


> Fix malformed VAULT_LOCAL_CONFIG JSON in docker-compose.yml
> -----------------------------------------------------------
>
>                 Key: AIRAVATA-3972
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-3972
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Custos Airavata Integration
>         Environment: Local development environment using docker-compose
>            Reporter: Jayanth Vennamreddy
>            Priority: Minor
>              Labels: bug, config, dev-exp
>
> While reviewing the development setup, I noticed that the VAULT_LOCAL_CONFIG 
> value in compose/docker-compose.yml contains malformed JSON.
> Current configuration:
> '\{"listener": [...], "default_lease_ttl": "168h", "max_lease_ttl": "720h"}, 
> "ui": true}'
> The closing brace is misplaced, causing the "ui": true property to be outside 
> the JSON object. This results in invalid JSON and may prevent Vault from 
> correctly enabling the UI when running the local development stack.
> Proposed fix:
> Move the closing brace to include the "ui" field within the JSON object:
> '\{"listener": [...], "default_lease_ttl": "168h", "max_lease_ttl": "720h", 
> "ui": true}'
> Impact:
> - Ensures valid JSON configuration
> - Enables Vault UI correctly in local development
> - Improves developer experience when running docker-compose
> I can open a PR to fix this if this approach looks good.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to