Anurag-S1ngh opened a new pull request, #200: URL: https://github.com/apache/airavata-django-portal/pull/200
## Summary The `adpf-queue-settings-editor` web component can dispatch `updateNodeCount` and `updateTotalCPUCount` while the `queue` getter still resolves to `null`, for example before the selected queue has loaded or when the stored queue name no longer matches the compute resource. Both actions then read `getters.queue.cpuPerNode` and throw a TypeError. ## Changes `django_airavata/apps/workspace/static/django_airavata_workspace/js/web-components/store.js` - read `getters.queue` once in each action and require it before the CPU conversion - the primary node or CPU count still updates, only the derived value is skipped `django_airavata/apps/workspace/static/django_airavata_workspace/tests/unit/web-components/store.spec.js` - two regression tests with `queue: null` for `updateNodeCount` and `updateTotalCPUCount` ## Testing - `cd django_airavata/apps/workspace && npx jest tests/unit/web-components/store.spec.js`: 33 passed - the two new tests fail on the unpatched file and pass with the fix - ESLint and Prettier on both changed files Closes #199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
