yasithdev commented on code in PR #666:
URL: https://github.com/apache/airavata-custos/pull/666#discussion_r4493803695


##########
extensions/SSH-Certificate-Signer/internal/handler/sign.go:
##########
@@ -48,16 +48,17 @@ type SignRequest struct {
 }
 
 type SignResponse struct {
-       Certificate       string   `json:"certificate"`
-       SerialNumber      int64    `json:"serial_number"`
-       ValidAfter        int64    `json:"valid_after"`
-       ValidBefore       int64    `json:"valid_before"`
-       CAFingerprint     string   `json:"ca_fingerprint"`
-       TargetHost        string   `json:"target_host"`
-       TargetPort        int      `json:"target_port"`
-       TargetUsername    string   `json:"target_username"`
-       ForceCommand      string   `json:"force_command,omitempty"`
-       GrantedExtensions []string `json:"granted_extensions"`
+       Certificate       string           `json:"certificate"`
+       SerialNumber      int64            `json:"serial_number"`
+       ValidAfter        int64            `json:"valid_after"`
+       ValidBefore       int64            `json:"valid_before"`
+       CAFingerprint     string           `json:"ca_fingerprint"`
+       TargetHost        string           `json:"target_host"`
+       TargetPort        int              `json:"target_port"`
+       TargetUsername    string           `json:"target_username"`
+       ForceCommand      string           `json:"force_command,omitempty"`
+       GrantedExtensions []string         `json:"granted_extensions"`
+       TimingMicros      map[string]int64 `json:"timing_micros,omitempty"`

Review Comment:
   @lahirujayathilake do we need this timingmicros? unless we explicitly use it 
for auditing/reporting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to