yasithdev commented on code in PR #751:
URL: https://github.com/apache/airavata-custos/pull/751#discussion_r4607757828
##########
extensions/SSH-Certificate-Signer/README.md:
##########
@@ -248,15 +248,28 @@ The service handles SIGTERM and SIGINT for graceful
shutdown:
| `GET` | `/api/v1/certificates/{serial}` | One certificate, with the
`login_host` and `login_port` to use it on |
| `POST` | `/api/v1/certificates/{serial}/revoke` | Revoke an active
certificate. `revoked_by` is required and `reason` can be empty |
| `GET` | `/api/v1/health` | Health check, no token
|
+| `GET` | `/api/v1/krl` | The revocation list for
`RevokedKeys`, no token. `ETag` is its version |
Every route with a token takes `Authorization: Bearer <service token>`.
`q` matches the serial, principal, email or key ID. `status` is `active`,
`not-yet-valid`, `expired` or `revoked`.
`GET /api/v1/certificates` uses keyset pagination. Pass `limit`, and `cursor`
set to the last `next_cursor`.
It returns no total or offset.
-> **Revocation.** The signer records revocations. It does not generate or
distribute OpenSSH KRLs, so login nodes still
-> accept a revoked certificate.
+### Revocation
+
+A revoke writes a row, then the signer rebuilds the OpenSSH revocation list
(KRL) from every revoked certificate that
+has not expired and writes it to `signer.krl.path`, the file the login nodes'
`RevokedKeys` points at, on storage they
+share with the signer. It writes a temp file next to it and renames, so the
file is never missing or half written. The
+same bytes are served at `/api/v1/krl` for a node without that storage. The
list is rebuilt every `refresh_seconds`
+too, so expired serials drop out, a failed write is retried and a file that
went missing is written again. Login nodes
+see a new list once their NFS attribute cache refreshes, about a minute.
Review Comment:
also mention that revoked_keys file is shared access between signer (writes
to file) and login node (reads before granting access)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]