[ 
https://issues.apache.org/jira/browse/AMBARI-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202045#comment-15202045
 ] 

Nate Cole commented on AMBARI-15388:
------------------------------------

How is <order> being maintained?  The <order> element is key to indicate 
dependencies for upgrading, and is not random.  Oozie must go before Falcon (at 
the service level).  Datanodes must be upgraded before RegionServers before 
NodeManagers within the same host.  The CLIENTS group spans multiple services.

 What about pre-requisite checks?  Order there also may be important.  
ClusterGrouping definitely has order - you can't execute Save Database State 
before HDFS Finalization occurs.

<priority> within a service check group is also important.

It's difficult to see all the changes based on just a plain text diff, can you 
add Review Board review or create a feature branch?  This is a really large 
commit.  We also have to balance stability here, especially when trying to 
maintain upgrade packs.  It's already hard enough maintaining the 
source->target upgrade packs, but if we now need one per service as well, that 
increases the number of files as a multiple of the number of services.

> Upgrade XML should be pushed down as much as possible to the services
> ---------------------------------------------------------------------
>
>                 Key: AMBARI-15388
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15388
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>    Affects Versions: trunk
>            Reporter: Tim Thorpe
>            Assignee: Tim Thorpe
>             Fix For: trunk
>
>         Attachments: AMBARI-15388.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version.  Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service.  It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to