[ 
https://issues.apache.org/jira/browse/AMBARI-15678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223751#comment-15223751
 ] 

Hadoop QA commented on AMBARI-15678:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12796710/AMBARI-15678.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6164//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6164//console

This message is automatically generated.

> YARN service_check doesn't fail when application status is not reasonable
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-15678
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15678
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: trunk
>         Environment: CentOS 6.5
>            Reporter: Masahiro TANAKA
>              Labels: easyfix, patch-available
>         Attachments: AMBARI-15678.patch
>
>
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN 
> [service_check.py|https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py#L130],
>  it doesn't fail because raise statement is in try block and there is only 
> `pass` in except block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to