[ 
https://issues.apache.org/jira/browse/AMBARI-15761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230345#comment-15230345
 ] 

Hadoop QA commented on AMBARI-15761:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12797524/AMBARI-15761.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6284//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6284//console

This message is automatically generated.

> While creating WEB URLs for Alerts, if we add http/https then we should not 
> drop the URL path past port number
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-15761
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15761
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 2.2.2
>
>         Attachments: AMBARI-15761.patch
>
>
> As an example, look at the following alert:
>     
>     
>     
>      "APP_TIMELINE_SERVER": [
>           {
>             "name": "yarn_app_timeline_server_webui",
>             "label": "App Timeline Web UI",
>             "description": "This host-level alert is triggered if the App 
> Timeline Server Web UI is unreachable.",
>             "interval": 5,
>             "scope": "ANY",
>             "source": {
>               "type": "WEB",
>               "uri": {
>                 "http": 
> "{{yarn-site/yarn.timeline-service.webapp.address}}/ws/v1/timeline",
>                 "https": 
> "{{yarn-site/yarn.timeline-service.webapp.https.address}}/ws/v1/timeline",
>                 "https_property": "{{yarn-site/yarn.http.policy}}",
>                 "https_property_value": "HTTPS_ONLY",
>                 "kerberos_keytab": 
> "{{yarn-site/yarn.timeline-service.http-authentication.kerberos.keytab}}",
>                 "kerberos_principal": 
> "{{yarn-site/yarn.timeline-service.http-authentication.kerberos.principal}}",
>                 "connection_timeout": 5.0
>               },
>               "reporting": {
>                 "ok": {
>                   "text": "HTTP {0} response in {2:.3f}s"
>                 },
>                 "warning":{
>                   "text": "HTTP {0} response from {1} in {2:.3f}s ({3})"
>                 },
>                 "critical": {
>                   "text": "Connection failed to {1} ({3})"
>                 }
>               }
>             }
>           }
>         ]
>       }
>     
> Specifically lines:
>     
>     
>     
>                 "http": 
> "{{yarn-site/yarn.timeline-service.webapp.address}}/ws/v1/timeline",
>                 "https": 
> "{{yarn-site/yarn.timeline-service.webapp.https.address}}/ws/v1/timeline",
>     
> These properties e.g. `yarn-site/yarn.timeline-service.webapp.address` are of
> the form `host:port`. So the logic that adds http/https does not preserve that
> the URL has `ws/v1/timeline` at the end.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to