[
https://issues.apache.org/jira/browse/AMBARI-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255095#comment-15255095
]
Hadoop QA commented on AMBARI-15609:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12800328/AMBARI-15609.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6624//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6624//console
This message is automatically generated.
> Refactor get_stack_to_component() method
> ----------------------------------------
>
> Key: AMBARI-15609
> URL: https://issues.apache.org/jira/browse/AMBARI-15609
> Project: Ambari
> Issue Type: Technical task
> Components: ambari-agent, ambari-server
> Affects Versions: 2.1.0, 2.2.0
> Reporter: Juanjo Marron
> Assignee: Juanjo Marron
> Priority: Minor
> Fix For: 2.4.0
>
> Attachments: AMBARI-15609.patch
>
>
> The original intention of the get_stack_to_component function was to have a
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should
> just return the string with the component name and no need to check
> params.stack_name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
