[
https://issues.apache.org/jira/browse/AMBARI-16158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262377#comment-15262377
]
Hadoop QA commented on AMBARI-16158:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12801238/AMBARI-16158.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6707//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6707//console
This message is automatically generated.
> takeover_config_merge.py should process known template config files
> -------------------------------------------------------------------
>
> Key: AMBARI-16158
> URL: https://issues.apache.org/jira/browse/AMBARI-16158
> Project: Ambari
> Issue Type: Bug
> Reporter: Andrew Onischuk
> Assignee: Andrew Onischuk
> Fix For: 2.4.0
>
> Attachments: AMBARI-16158.patch
>
>
> `/var/lib/ambari-server/resources/scripts/takeover_config_merge.py` currently
> only processes XML content files (*-site.xml, etc.). However there are a lot
> of other files which need to end up managed by Ambari.
> At a minimum this script should load in the known template type files (*-env,
> *-log4j, etc.). Also, it should take care of capacity-scheduler configs.
> Not processing these files will result in too much effort for users into
> getting their content, removing new lines, and making them JSON compliant - to
> keep into the blueprint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)