[ 
https://issues.apache.org/jira/browse/AMBARI-16136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264535#comment-15264535
 ] 

Hadoop QA commented on AMBARI-16136:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12801472/AMBARI-16136.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6733//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6733//console

This message is automatically generated.

> Make temp filenames unique when creating files
> ----------------------------------------------
>
>                 Key: AMBARI-16136
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16136
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-agent
>    Affects Versions: 2.2.1.1
>            Reporter: Sandor Magyari
>            Assignee: Sandor Magyari
>             Fix For: 2.2-next
>
>         Attachments: AMBARI-16136.patch
>
>
> When creating files on linux, ambari-agent use create_file() in sudo.py. Here 
> first a temp file created, copied over the right place later. The filename of 
> this temp file currently is:     tmpf_name = tempfile.gettempdir() + os.sep + 
> tempfile.template + str(time.time()). This may cause problems in case of 
> parallel executions, thread name or something random should be added to be 
> more unique.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to