[ 
https://issues.apache.org/jira/browse/AMBARI-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt updated AMBARI-16758:
--------------------------
    Description: 
Refactor HAWQ and PXF unit tests

[~lavjain] notes: 
```
ExecuteScript can be a separate function with command passed in as parameter.

Similarily, common.stop_component can be refactored into a separate function 
with both test_stop_default and test_activate_hawq_standby calling it.

If you want to go one step further, create a base class of 
TestHawqCommon(RMFTestCase) that defines the corresponding routines in 
common.py with TestHawqStandby(TestHawqCommon).

assertResourceCalled can be defined using functools.partial
```

  was:Refactor HAWQ and PXF unit tests


> Revisit HAWQ and PXF unit tests and refactor code
> -------------------------------------------------
>
>                 Key: AMBARI-16758
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16758
>             Project: Ambari
>          Issue Type: Technical task
>          Components: stacks
>            Reporter: Matt
>            Priority: Minor
>             Fix For: trunk
>
>
> Refactor HAWQ and PXF unit tests
> [~lavjain] notes: 
> ```
> ExecuteScript can be a separate function with command passed in as parameter.
> Similarily, common.stop_component can be refactored into a separate function 
> with both test_stop_default and test_activate_hawq_standby calling it.
> If you want to go one step further, create a base class of 
> TestHawqCommon(RMFTestCase) that defines the corresponding routines in 
> common.py with TestHawqStandby(TestHawqCommon).
> assertResourceCalled can be defined using functools.partial
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to