[
https://issues.apache.org/jira/browse/AMBARI-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316999#comment-15316999
]
Hadoop QA commented on AMBARI-17047:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12808206/AMBARI-17047.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7189//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7189//console
This message is automatically generated.
> Firewall check returns WARNING even if iptables and firewalld are stopped on
> CentOS7
> ------------------------------------------------------------------------------------
>
> Key: AMBARI-17047
> URL: https://issues.apache.org/jira/browse/AMBARI-17047
> Project: Ambari
> Issue Type: Bug
> Components: ambari-agent, ambari-server
> Affects Versions: trunk
> Environment: CentOS7.2
> Reporter: Masahiro Tanaka
> Labels: patch
> Attachments: AMBARI-17047.patch
>
>
> In firewall.py, {{"systemctl is-active iptables || systemctl is-active
> firewalld"}} is passed to {{run_in_shell}} function, which splits cmd string
> by using {{shlex.split}}.
> {{run_in_shell}} function finally calls {{subprocess.Popen}} with
> {{shell=True}}, so the cmd string is evaluated like {{Popen(['/bin/sh', '-c',
> 'systemctl', 'is-active', 'iptables', '||', 'systemctl', 'is-active',
> 'firewalld'])}}. This doesn't returns values as expected, because after
> args[1] (in this case, after the first {{is-active}}) are evaluated as sh
> arguements.
> {{systemctl is-active}} can take multiple arugments, so we can use it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
